Thomas Lohrum wrote:exclusive lock works a lot faster on large imports
Yes, it is generally noticeably faster. And contrary to my expectations, doesn't impede Dropbox syncing. That's why I decided to make it the default, and even made some changes to the code so that it never needs to open a second connection to the DB.
Thomas Lohrum wrote:please, can you explain what mode was used previously and what are the advantages and disadvantages of exclusive lock (besides faster writes)
I will hardly explain it better than the creator of SQLite
. In short, exclusive lock makes operations a bit faster, but doesn't allow simultaneous connections to the database. In practice this means that you won't be able to open the DB in SQLite browser tools while CN is running. Also it won't be possible to open the same DB in two different CN instances at the same time - the second instance will display the "database locked" error.
Thomas Lohrum wrote:the drawing of the notes attachments list does not look well on the bottom in the editor; maybe a divider can be added
Ok, will do, thanks
Thomas Lohrum wrote:having the list of notes attachments beneath the editor (rather than on the right side) would allow to show filenames without word wrap
I have plans to display nice full-width previews for attached images (instead of just icons), and horizontal layout won't be great for this IMO.
But we could implement auto-sizing, so that the width of the attachments list automatically increases (up to a certain percentage, of course) when you attach files with long names.
Thomas Lohrum wrote:there is no warning when adding the same attachment twice; but that's probably ok. On the other hand a dialog can be helpful. "The file is attached already. Replace it with the file from the external disk?"
Behind the scenes that file is attached, its hash is calculated, and if CN sees that the hash matches the hash of an already attached file, the operation is cancelled. On the other hand, if file contents is different, it will be attached even if it has the same name. I think the best approach would be to display this warning only if the note already has an attachment with the same name, but different contents. If contents also are the same, I think it would be ok just to silently focus the corresponding attached item. What do you think?
Thomas Lohrum wrote:
dragging to resize the notes attachment area is nice
However, the value is not saved in the settings file yet. Probably because it depends on the window (size) which was used at edit time.
Yes, I considered that it probably should either be saved for each note individually, or not saved at all. And we can't save this info into the notebook, since it essentially is view state and should work for read-only notebooks as well. Probably the auto-expansion feature will reduce the necessity to save this info.
Thomas Lohrum wrote:a file size of 3.38184 Mb should be shown with two digits only, e.g. 3.38 Mb
Will be fixed in Beta 2, thanks
Thomas Lohrum wrote:a file size of less than 1 Kb should be shown in bytes (right now zero is displayed which is not helpful)
Will be fixed in Beta 2, thanks
Thomas Lohrum wrote:When minimizing the attachments list area, so that only the icons will be visible, a hint should be available with the attachment's filename.
Yes, I planned to do this. Will do in Beta2.
Thomas Lohrum wrote:Maybe showing only icons (and hints) should be the default, thus minimizing space requirements. It also looks quite nice. The only drawback i can think of is, when there are many attachments. Personally i expect many people to have one attachment per note. But as the feature is implemented nicely, people might use it with many attachments per note.
I'm not sure about this, I guess the current default width is better for displaying image previews. But this could be an option. Let's leave it as an idea for a future improvement.
Thomas Lohrum wrote:Removing (deleting) an attachment should require a confirmation, which can be turned off optionally.
The attachment is not really deleted until you save the note. Just press cancel and the attachment is back. This makes it a double confirmation - do you think it is necessary?