1.5.1 URL link display is broken

Thomas Lohrum
Posts: 1316
Joined: Tue Mar 08, 2011 11:15 am

1.5.1 URL link display is broken

Postby Thomas Lohrum » Wed Nov 09, 2011 12:33 am

With 1.5.1 a link inside a note is marked wrong.

good example 1:

* CintaNotes (http://www.cintanotes.com) is a very nice tool


bad example :

* CintaNotes (http://www.cintanotes.com) is a very nice tool

The bad example show's, that the selection of the link is shifted. When you double-click the link the browser open's "tes (http://www.cintanote" which will result in error 404.
User avatar
CintaNotes Developer
Site Admin
Posts: 4745
Joined: Fri Dec 12, 2008 4:45 pm
Contact:

Re: 1.5.1 URL link display is broken

Postby CintaNotes Developer » Wed Nov 09, 2011 1:07 am

Thanks for the report!

Is this a new note or has it been created prior to upgrading to 1.5.1?
Does editing the note and saving it help?
Alex
Thomas Lohrum
Posts: 1316
Joined: Tue Mar 08, 2011 11:15 am

Re: 1.5.1 URL link display is broken

Postby Thomas Lohrum » Wed Nov 09, 2011 10:59 pm

CintaNotes Developer wrote:Is this a new note or has it been created prior to upgrading to 1.5.1?
The note was created with 1.5.1.
CintaNotes Developer wrote:Does editing the note and saving it help?
Yes. I also discovered that this bug relates to my report to the "unwanted spaces". Links that are broken obviously have those unwanted spaces at the end. When i delete the spaces the link magically get's fixed. That is, this might not be a new bug, but possibly a side effect of the "spaces-bug".
User avatar
CintaNotes Developer
Site Admin
Posts: 4745
Joined: Fri Dec 12, 2008 4:45 pm
Contact:

Re: 1.5.1 URL link display is broken

Postby CintaNotes Developer » Thu Nov 10, 2011 4:46 am

Thomas, huge thanks for your help!

It can be related to spaces, but it can be also related to newlines. I've had this bug when somewhere in the note there were CRLFs instead of just CRs. But now I'm having trouble reproducing the bug.
How was this note (and those links) created, via clipping, pasting or Ins+manual editing?
Could you please come up with a minimal series of steps needed to reproduce it? Thanks!
Alex
Thomas Lohrum
Posts: 1316
Joined: Tue Mar 08, 2011 11:15 am

Re: 1.5.1 URL link display is broken

Postby Thomas Lohrum » Thu Nov 10, 2011 10:15 am

Alex, you're welcome! :D

I have generated a testcase. Maybe the steps can be reduced, but here is how it goes.

Steps to reproduce:
insert a new note (i use the global shortcut)
start inside the note, not the title
insert "* 11111111"
press ENTER
insert " " (two spaces)
paste link from clipboard "http://www.collab.net/downloads/subversion/"
press ENTER
press ENTER
press HOME
insert "* 22222222"
press ENTER
press ENTER ---> now two spaces were auto-inserted and the cursor is in col=3
press HOME
insert "* 33333333"
insert " " (two spaces)
paste link from clipboard "http://www.collab.net/downloads/subversion/"
press ENTER
press ESC ---> save and exit
reopen the note
move the cursor behind the second line
---> " http://www.collab.net/downloads/subversion/"
press ENTER
press ESC ---> save and exit
reopen the note
now you can see the last line is broken

The resulting text:
* 1111111
http://www.collab.net/downloads/subversion/


* 2222222

* 3333333
http://www.collab.net/downloads/subversion/
User avatar
CintaNotes Developer
Site Admin
Posts: 4745
Joined: Fri Dec 12, 2008 4:45 pm
Contact:

Re: 1.5.1 URL link display is broken

Postby CintaNotes Developer » Thu Nov 10, 2011 5:10 pm

Thanks a lot, now I have been able to reproduce it. Will be fixed in the next update!
Alex
User avatar
CintaNotes Developer
Site Admin
Posts: 4745
Joined: Fri Dec 12, 2008 4:45 pm
Contact:

Re: 1.5.1 URL link display is broken

Postby CintaNotes Developer » Sat Nov 12, 2011 7:34 pm

Thomas, I think I've fixed the bug.
May I ask you to confirm that it is really done with?
Here is the fixed version: http://cintanotes.com/private/CintaNotes_1_5_2.zip

Thanks in advance!
Alex
Thomas Lohrum
Posts: 1316
Joined: Tue Mar 08, 2011 11:15 am

Re: 1.5.1 URL link display is broken

Postby Thomas Lohrum » Sat Nov 12, 2011 8:55 pm

Alex, i have downloaded and successfully corrected notes previously created with 1.5.1. I will observe whether the bug is gone or not and report to you asap. However, i have noticed that spaces at the end of the line are still preserved. I would like to see those spaced removed when moving to another line or when saving the note. Thank you!

Thomas

PS: The exe size is almost 2 MB. I guess it is compiled with debug info.
User avatar
CintaNotes Developer
Site Admin
Posts: 4745
Joined: Fri Dec 12, 2008 4:45 pm
Contact:

Re: 1.5.1 URL link display is broken

Postby CintaNotes Developer » Sun Nov 13, 2011 7:02 am

Sorry, I haven't done anything with the spaces yet. I will try, but probably it won't make it into the 1.5.2 update.
For now I've just fixed the corrupted link problem.

As for the executable size - I forgot to run UPX on executable, that's actually real CN size. (Boost and SQLite and statically linked runtime contribute to that, but it is better than receiving "CintaNotes won't run because MSVCRT80.DLL was not found" ;)
If you re-download the size will be as usual.
Alex
Thomas Lohrum
Posts: 1316
Joined: Tue Mar 08, 2011 11:15 am

Re: 1.5.1 URL link display is broken

Postby Thomas Lohrum » Thu Nov 24, 2011 3:23 pm

Thomas Lohrum wrote:Alex, i have downloaded and successfully corrected notes previously created with 1.5.1. I will observe whether the bug is gone or not and report to you asap.

I have checked all notes created and edited with 1.5.2 after November 12. Looking good :)

Return to “Bug Reports”