Page 1 of 1

Tag autocomplete/suggestion became unsorted mess @2.8

Posted: Sat Oct 18, 2014 6:41 am
by Aelius
I just noticed, after having updated to 2.8, that whenever I am adding a note and I am typing in the tag field and the dropdown suggestion of tags appears (or when I press Ctrl+Space in the tag entry field) it's a complete mess. Prior to 2.8 it was organized alphabetically, but now it seems to be utterly random. The tag sidebar, on the other hand, remains alphabetically organized as it should be.

Was this changed intentionally, is there an option to change it back, or is this not something others are experiencing?

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Posted: Sat Oct 18, 2014 6:49 am
by CintaNotes Developer
Hi Aelius,
thanks for the report!
This is a bug and we'll fix it asap.
I wonder why it wasn't noticed in one of the betas..
Thanks!

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Posted: Sat Oct 18, 2014 7:04 am
by usbpoweredfridge
CintaNotes Developer wrote:I wonder why it wasn't noticed in one of the betas..


Can't answer for anyone else, but I don't recall an occasion where my dropdown has ever shown anything but one single suggestion, so I would never have noticed it.

Chris

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Posted: Sat Oct 18, 2014 7:13 am
by Aelius
Ah, cool, glad I could help! I was just worried it was something I did wrong myself :P No worries, it happens, and I know you guys are always on the ball to get things fixed up :) Thanks.

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Posted: Sat Oct 18, 2014 7:44 am
by CintaNotes Developer
Please try this fix:

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Posted: Sat Oct 18, 2014 10:00 am
by Aelius
CintaNotes Developer wrote:Please try this fix:


Thanks for the super fast fix! It seems to work fine now just like it was before 2.8 :) thanks again.

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Posted: Sat Oct 18, 2014 11:11 am
by CintaNotes Developer
Welcome, and thanks again for the bug report! Not everyone takes the time..

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Posted: Tue Oct 21, 2014 7:26 pm
by Thomas Lohrum
CintaNotes Developer wrote:I wonder why it wasn't noticed in one of the betas..

Usually i type 3-4 characters before i even focus on the tag list. Normally this gives me a list of 2-3 tags. I focus on searching the item without paying attention on the order. Since we don't know when this bug was introduced, it is also hard to tell, at which point in time it could have been noticed. Alex, you did not notice yourself?! LOL, you coded it, didn't you? ;)

Thomas

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Posted: Wed Oct 22, 2014 5:38 am
by CintaNotes Developer
Thomas Lohrum wrote:Usually i type 3-4 characters before i even focus on the tag list. Normally this gives me a list of 2-3 tags. I focus on searching the item without paying attention on the order. Since we don't know when this bug was introduced, it is also hard to tell, at which point in time it could have been noticed. Alex, you did not notice yourself?! LOL, you coded it, didn't you? ;)


Of course I coded it ;) There's a reason they don't let programmers test own code ;)
But anyway, I'm far for playing the blame game - I think the beta testers did a great job overall.

Here's what happened, for those interested. Before 2.8, tag sorting was automatic because a sorted container for tag collections was used (std::map). In 2.8, we migrated to a faster hash-based container which doesn't keep its elements in a sorted order (stdext::hash_map). So now the tags need to be sorted manually before display. In many places I didn't forget it - in tag sidebar or note preview, for example. But this one slipped through, sorry.

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Posted: Wed Oct 22, 2014 7:07 am
by Thomas Lohrum
CintaNotes Developer wrote:[Here's what happened, for those interested. Before 2.8, tag sorting was automatic because a sorted container for tag collections was used (std::map). In 2.8, we migrated to a faster hash-based container which doesn't keep its elements in a sorted order (stdext::hash_map). So now the tags need to be sorted manually before display. In many placed I didn't forget it - in tag sidebar or note preview, for example. But this one slipped out, sorry.

Cool, thanks for the explanation. Probably there are only few people around, at least in the forum, that will understand it though ;) I do :)

Thomas

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Posted: Wed Oct 22, 2014 11:06 am
by CintaNotes Developer
I knew that you would understand.. But also don't underestimate other CN users - there are many software engineers among them (no one else can handle the software lol :)

Anyhow, I've included the fix into 2.8.1 Beta 1