Tag autocomplete/suggestion became unsorted mess @2.8

Aelius
Posts: 7
Joined: Sat Aug 16, 2014 5:08 am
Contact:

Tag autocomplete/suggestion became unsorted mess @2.8

Postby Aelius » Sat Oct 18, 2014 6:41 am

I just noticed, after having updated to 2.8, that whenever I am adding a note and I am typing in the tag field and the dropdown suggestion of tags appears (or when I press Ctrl+Space in the tag entry field) it's a complete mess. Prior to 2.8 it was organized alphabetically, but now it seems to be utterly random. The tag sidebar, on the other hand, remains alphabetically organized as it should be.

Was this changed intentionally, is there an option to change it back, or is this not something others are experiencing?
User avatar
CintaNotes Developer
Site Admin
Posts: 4689
Joined: Fri Dec 12, 2008 4:45 pm
Contact:

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Postby CintaNotes Developer » Sat Oct 18, 2014 6:49 am

Hi Aelius,
thanks for the report!
This is a bug and we'll fix it asap.
I wonder why it wasn't noticed in one of the betas..
Thanks!
Alex
User avatar
usbpoweredfridge
Posts: 407
Joined: Fri Jan 17, 2014 11:08 pm
Contact:

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Postby usbpoweredfridge » Sat Oct 18, 2014 7:04 am

CintaNotes Developer wrote:I wonder why it wasn't noticed in one of the betas..


Can't answer for anyone else, but I don't recall an occasion where my dropdown has ever shown anything but one single suggestion, so I would never have noticed it.

Chris
Last edited by usbpoweredfridge on Sat Oct 18, 2014 7:17 am, edited 1 time in total.
Aelius
Posts: 7
Joined: Sat Aug 16, 2014 5:08 am
Contact:

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Postby Aelius » Sat Oct 18, 2014 7:13 am

Ah, cool, glad I could help! I was just worried it was something I did wrong myself :P No worries, it happens, and I know you guys are always on the ball to get things fixed up :) Thanks.
User avatar
CintaNotes Developer
Site Admin
Posts: 4689
Joined: Fri Dec 12, 2008 4:45 pm
Contact:

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Postby CintaNotes Developer » Sat Oct 18, 2014 7:44 am

Please try this fix:
Attachments
CintaNotes_2_8_1_Beta0.zip
(6.64 MiB) Downloaded 222 times
Alex
Aelius
Posts: 7
Joined: Sat Aug 16, 2014 5:08 am
Contact:

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Postby Aelius » Sat Oct 18, 2014 10:00 am

CintaNotes Developer wrote:Please try this fix:


Thanks for the super fast fix! It seems to work fine now just like it was before 2.8 :) thanks again.
User avatar
CintaNotes Developer
Site Admin
Posts: 4689
Joined: Fri Dec 12, 2008 4:45 pm
Contact:

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Postby CintaNotes Developer » Sat Oct 18, 2014 11:11 am

Welcome, and thanks again for the bug report! Not everyone takes the time..
Alex
Thomas Lohrum
Posts: 1309
Joined: Tue Mar 08, 2011 11:15 am

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Postby Thomas Lohrum » Tue Oct 21, 2014 7:26 pm

CintaNotes Developer wrote:I wonder why it wasn't noticed in one of the betas..

Usually i type 3-4 characters before i even focus on the tag list. Normally this gives me a list of 2-3 tags. I focus on searching the item without paying attention on the order. Since we don't know when this bug was introduced, it is also hard to tell, at which point in time it could have been noticed. Alex, you did not notice yourself?! LOL, you coded it, didn't you? ;)

Thomas
User avatar
CintaNotes Developer
Site Admin
Posts: 4689
Joined: Fri Dec 12, 2008 4:45 pm
Contact:

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Postby CintaNotes Developer » Wed Oct 22, 2014 5:38 am

Thomas Lohrum wrote:Usually i type 3-4 characters before i even focus on the tag list. Normally this gives me a list of 2-3 tags. I focus on searching the item without paying attention on the order. Since we don't know when this bug was introduced, it is also hard to tell, at which point in time it could have been noticed. Alex, you did not notice yourself?! LOL, you coded it, didn't you? ;)


Of course I coded it ;) There's a reason they don't let programmers test own code ;)
But anyway, I'm far for playing the blame game - I think the beta testers did a great job overall.

Here's what happened, for those interested. Before 2.8, tag sorting was automatic because a sorted container for tag collections was used (std::map). In 2.8, we migrated to a faster hash-based container which doesn't keep its elements in a sorted order (stdext::hash_map). So now the tags need to be sorted manually before display. In many places I didn't forget it - in tag sidebar or note preview, for example. But this one slipped through, sorry.
Alex
Thomas Lohrum
Posts: 1309
Joined: Tue Mar 08, 2011 11:15 am

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Postby Thomas Lohrum » Wed Oct 22, 2014 7:07 am

CintaNotes Developer wrote:[Here's what happened, for those interested. Before 2.8, tag sorting was automatic because a sorted container for tag collections was used (std::map). In 2.8, we migrated to a faster hash-based container which doesn't keep its elements in a sorted order (stdext::hash_map). So now the tags need to be sorted manually before display. In many placed I didn't forget it - in tag sidebar or note preview, for example. But this one slipped out, sorry.

Cool, thanks for the explanation. Probably there are only few people around, at least in the forum, that will understand it though ;) I do :)

Thomas
User avatar
CintaNotes Developer
Site Admin
Posts: 4689
Joined: Fri Dec 12, 2008 4:45 pm
Contact:

Re: Tag autocomplete/suggestion became unsorted mess @2.8

Postby CintaNotes Developer » Wed Oct 22, 2014 11:06 am

I knew that you would understand.. But also don't underestimate other CN users - there are many software engineers among them (no one else can handle the software lol :)

Anyhow, I've included the fix into 2.8.1 Beta 1
Alex

Return to “Bug Reports”